ignore: remove dulwich in favour of pathspec#2159
Merged
Merged
Conversation
Suor
approved these changes
Jun 20, 2019
Contributor
Suor
left a comment
There was a problem hiding this comment.
Looks like straightforward simplification 👍
The whole ignore thing looks too complicated though, but this PR is certainly not about that.
Contributor
Author
2 tasks
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have you followed the guidelines in our
Contributing document?
Does your PR affect documented changes or does it add new functionality
that should be documented? If yes, have you created a PR for
dvc.org documenting it or at
least opened an issue for it? If so, please add a link to it.
related to #1876
Edit:
When (if) this change is approved, we should create issue to optimize pathspec usage. Now, during dvc_walk we check files one by one, while pathspec allows to check set/list of paths against spec.
Edit 2:
But first it might be better to do some performance testing if its worth our time