sort dvc pipeline list output#2588
Closed
DmitriyVahrushev wants to merge 1 commit into
Closed
Conversation
efiop
suggested changes
Oct 9, 2019
Contributor
efiop
left a comment
efiop
left a comment
There was a problem hiding this comment.
Hi @DmitriyVahrushev !
Thank you so much for the PR! 🙂 Please see a comment attached.
| for p in pipelines: | ||
| stages = networkx.get_node_attributes(p, "stage") | ||
| for stage in stages: | ||
| for stage in sorted(stages): |
Contributor
There was a problem hiding this comment.
Unfortunately, this is not the way to solve the original issue. You are sorting alphabetically, but the original issue is about sorting in the order of execution, basically the way dvc repro does it. See https://github.com/iterative/dvc/blob/0.62.0/dvc/repo/reproduce.py#L172 . So what we need to do here is to print them in the order of dfs_postorder, same as it is in the dvc repro's usual way of execution.
Contributor
|
Hi! How is it going? Need any help? :) |
Contributor
|
@DmitriyVahrushev Need any help? 🙂 |
Closed
Contributor
|
Closing in favour of #2669 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2452
Should i write test for this? Also i found two test in test_pipeline.py TestPipelineListSingle and TestPipelineListEmpty. Maybe i am wrong but seems like they're doing something strange.