Skip to content

gc: added --all-commits#2643

Merged
efiop merged 3 commits into
treeverse:masterfrom
Suor:all-commits
Oct 23, 2019
Merged

gc: added --all-commits#2643
efiop merged 3 commits into
treeverse:masterfrom
Suor:all-commits

Conversation

@Suor
Copy link
Copy Markdown
Contributor

@Suor Suor commented Oct 21, 2019

Plus fixed a bug in previous patch.

@Suor Suor requested a review from efiop October 21, 2019 16:27
@efiop
Copy link
Copy Markdown
Contributor

efiop commented Oct 21, 2019

@Suor Tests failed.

@Suor
Copy link
Copy Markdown
Contributor Author

Suor commented Oct 22, 2019

Fixed it

Comment thread dvc/command/gc.py Outdated
Comment thread tests/func/test_gc.py Outdated
Suor added 2 commits October 23, 2019 20:55
Say that we always leave things used in the working tree
@Suor
Copy link
Copy Markdown
Contributor Author

Suor commented Oct 23, 2019

Removed the print and fixed the warning. The last was actually a separate thing, so pretty commits here. Please merge @efiop ;)

Copy link
Copy Markdown
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@efiop efiop merged commit 3034143 into treeverse:master Oct 23, 2019
@efiop
Copy link
Copy Markdown
Contributor

efiop commented Oct 23, 2019

The last was actually a separate thing, so pretty commits here. Please merge @efiop ;)

@Suor Merges are disabled :D Only squash is available for consistency.

@Suor
Copy link
Copy Markdown
Contributor Author

Suor commented Oct 23, 2019

This was 3 unrelated commits.

@efiop
Copy link
Copy Markdown
Contributor

efiop commented Oct 23, 2019

@Suor I understand, but we now squash by default. If anyone needs more granularity, individual commits are available in the PR itself.

@efiop
Copy link
Copy Markdown
Contributor

efiop commented Oct 23, 2019

@Suor Please don't remove PR template. Did you submit a docs PR?

@efiop
Copy link
Copy Markdown
Contributor

efiop commented Oct 23, 2019

@Suor Created treeverse/dvc.org#730 . Please submit a doc PR.

@Suor
Copy link
Copy Markdown
Contributor Author

Suor commented Oct 24, 2019

@efiop this should be not documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants