Skip to content

Fixed issue #2680 and Simple typo rectified#2715

Merged
efiop merged 2 commits into
treeverse:masterfrom
ATR-oCiTy:master
Nov 3, 2019
Merged

Fixed issue #2680 and Simple typo rectified#2715
efiop merged 2 commits into
treeverse:masterfrom
ATR-oCiTy:master

Conversation

@ATR-oCiTy
Copy link
Copy Markdown
Contributor

@ATR-oCiTy ATR-oCiTy commented Nov 3, 2019

dvc/remote/s3.py : Rectified simple typo
dvc/updater.py : Removed "Cask 'dvc' is not installed." error

dvc/remote/s3.py:L148: transfered -> transferred
Deleted https://github.com/iterative/dvc/blob/0.66.3/dvc/updater.py#L126 and code block https://github.com/iterative/dvc/blob/0.66.3/dvc/updater.py#L173

Fixes #2680

Comment thread dvc/updater.py
else:
return "pip"

# NOTE: both pkg and cask put dvc binary into /usr/local/bin,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks a lot for fixing this!

@ATR-oCiTy ATR-oCiTy changed the title Simple typos mectified Fixed issue #2680 and Simple typo rectified Nov 3, 2019
Copy link
Copy Markdown
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@efiop efiop merged commit 1b54c7f into treeverse:master Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

install: "Cask 'dvc' is not installed." error

2 participants