Skip to content

fix PR template to mention recommendatory nature of CC and DS#2723

Merged
efiop merged 4 commits into
treeverse:masterfrom
shcheklein:fix-pr-template
Nov 4, 2019
Merged

fix PR template to mention recommendatory nature of CC and DS#2723
efiop merged 4 commits into
treeverse:masterfrom
shcheklein:fix-pr-template

Conversation

@shcheklein
Copy link
Copy Markdown
Contributor

  • Have you followed the guidelines in our
    Contributing document?

  • Does your PR affect documented changes or does it add new functionality
    that should be documented? If yes, have you created a PR for
    dvc.org documenting it or at
    least opened an issue for it? If so, please add a link to it.


Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
Copy link
Copy Markdown
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a final suggestion in #2723 (comment).

@efiop efiop merged commit e0fe8a8 into treeverse:master Nov 4, 2019
@efiop
Copy link
Copy Markdown
Contributor

efiop commented Nov 4, 2019

Thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants