Ensure contains_symlink_up_to accept both str and Path-like objects#2740
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
efiop
reviewed
Nov 5, 2019
efiop
reviewed
Nov 5, 2019
efiop
reviewed
Nov 5, 2019
| self.assertFalse(contains_symlink_up_to(target_path, base_path)) | ||
| self.assertFalse( | ||
| contains_symlink_up_to(PathInfo(target_path), PathInfo(base_path)) | ||
| ) |
Contributor
There was a problem hiding this comment.
For the record: Could also add a case for one str and one path_info, but the current one is good enough :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❗ Have you followed the guidelines in the Contributing to DVC list?
📖 Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.
❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addresses. Please review them carefully and fix those that actually improve code or fix bugs.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
With reference: #2137
These changes test if
contains_symlink_up_tocan accept bothstrandPathlike objects.I have purposely added theResolved here - #2740 (comment)patch.objectdecorator since I wanted to make the symlink true so that it comes out of recursion loop. There can be one addition to this test where we check for this condition as well - https://github.com/iterative/dvc/compare/master...algomaster99:test-arg-types-symlink?expand=1#diff-24be7b52326b428c2569724796020192R72. How to proceed with the latter?