makedirs: fix mode flag is being ignored starting from Python 3.7#2790
Conversation
|
shcheklein
requested review from
a user and
pared
and removed request for
efiop
|
One comment, also test for 2.7 fails. I tried to reproduce it on my computer, and it seems to fail only for first test run. Maybe something is not unset? Though its done in finally, so I am confused. |
👀 |
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
looks good to me; just adding that mode flag still works on >=3.7 but it doesn't affect anymore intermediate directories.
|
@MrOutis yep! thanks
yep, #2789 (comment) |
efiop
left a comment
efiop
left a comment
There was a problem hiding this comment.
Please see two comments up above.
| return | ||
|
|
||
| umask = os.umask(0) | ||
| umask = os.umask(0o777 - mode) |
There was a problem hiding this comment.
Let's put a comment explaining what is going on :)
| def test_makedirs_permissions(): | ||
| dir_mode = 0o755 | ||
| intermediate_dir = "тестовая-директория" | ||
| test_dir = os.path.join(intermediate_dir, "data") |
There was a problem hiding this comment.
You are creating this directory in the project's root, which is not nice. Please use tmpdir fixture or something like that.
There was a problem hiding this comment.
good point, simplified using tmpdir
3 participants
Fixes #2789
❗ Have you followed the guidelines in the Contributing to DVC list?
📖 Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.
❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addresses. Please review them carefully and fix those that actually improve code or fix bugs.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏