Refactor startswith with path_isin util#2832
Merged
Merged
Conversation
d391414 to
751bdb2
Compare
ghost
approved these changes
Nov 21, 2019
|
@skshetry , for S3 we use When working with |
Collaborator
Author
|
@MrOutis, yes, |
ghost
approved these changes
Nov 21, 2019
pared
reviewed
Nov 21, 2019
skshetry
commented
Nov 21, 2019
pared
approved these changes
Nov 21, 2019
7472dad to
751bdb2
Compare
ghost
approved these changes
Nov 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❗ Have you followed the guidelines in the Contributing to DVC list?
📖 Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.
❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.
Description
Resolves #2823
I did not feel brave enough ondvc.remote.s3.RemoteS3.exists.EDIT:
dvc.remote.s3.RemoteS3.existscannot be changed, aspath_isinis os-agnostic, whereas s3 requires posixpath.dvc/utils/__init__.py:260has a cyclic dependency problem.There are few other cases of
startswith, but are not related with filepaths (except fordvc/utils/__init__.pyat the end ⏬)Thank you for the contribution - we'll try to review it as soon as possible. 🙏