Skip to content

ui: warn about ignored options for dvc status and a grammar fix#3027

Merged
efiop merged 2 commits into
treeverse:masterfrom
Suor:status-noop
Jan 7, 2020
Merged

ui: warn about ignored options for dvc status and a grammar fix#3027
efiop merged 2 commits into
treeverse:masterfrom
Suor:status-noop

Conversation

@Suor
Copy link
Copy Markdown
Contributor

@Suor Suor commented Dec 31, 2019

A sidestep from #2386

Comment thread dvc/repo/status.py Outdated
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

Comment thread dvc/repo/status.py Outdated
@Suor
Copy link
Copy Markdown
Contributor Author

Suor commented Jan 3, 2020

Changed to exception.

@Suor Suor requested a review from efiop January 3, 2020 15:17
Comment thread dvc/repo/status.py Outdated
@Suor
Copy link
Copy Markdown
Contributor Author

Suor commented Jan 6, 2020

Changed to --options.

@Suor
Copy link
Copy Markdown
Contributor Author

Suor commented Jan 7, 2020

So? Is it ok now?

@Suor Suor requested a review from efiop January 7, 2020 09:54
Comment thread dvc/repo/status.py Outdated
@efiop efiop merged commit 249f6c5 into treeverse:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants