Skip to content

Ensure relpath accepts str and Path-like objects#3037

Merged
efiop merged 1 commit into
masterfrom
test-relpath
Jan 2, 2020
Merged

Ensure relpath accepts str and Path-like objects#3037
efiop merged 1 commit into
masterfrom
test-relpath

Conversation

@algomaster99
Copy link
Copy Markdown
Contributor

  • ❗ Have you followed the guidelines in the Contributing to DVC list?

  • 📖 Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.

  • ❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

Reference: #2137

@algomaster99 algomaster99 requested a review from efiop January 1, 2020 20:44
@algomaster99 algomaster99 changed the title Ensure accepts str and Path-like objects Ensure relpath accepts str and Path-like objects Jan 1, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 1, 2020

Codecov Report

Merging #3037 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3037      +/-   ##
==========================================
- Coverage   91.82%   91.82%   -0.01%     
==========================================
  Files         138      138              
  Lines        8555     8554       -1     
==========================================
- Hits         7856     7855       -1     
  Misses        699      699
Impacted Files Coverage Δ
dvc/state.py 91.01% <100%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6162fe...f08c90f. Read the comment docs.

@efiop efiop merged commit a377f9e into master Jan 2, 2020
@efiop
Copy link
Copy Markdown
Contributor

efiop commented Jan 2, 2020

Thanks!

@efiop efiop deleted the test-relpath branch January 2, 2020 14:46
@Suor Suor mentioned this pull request Jan 8, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants