Skip to content

http/ imp tests - migrate do dir helpers#3070

Merged
efiop merged 2 commits into
treeverse:masterfrom
pared:2896_http_imp
Jan 6, 2020
Merged

http/ imp tests - migrate do dir helpers#3070
efiop merged 2 commits into
treeverse:masterfrom
pared:2896_http_imp

Conversation

@pared
Copy link
Copy Markdown
Contributor

@pared pared commented Jan 6, 2020

  • ❗ Have you followed the guidelines in the Contributing to DVC list?

  • 📖 Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.

  • ❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

Copy link
Copy Markdown
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@efiop efiop merged commit 40449c4 into treeverse:master Jan 6, 2020
@pared pared deleted the 2896_http_imp branch March 24, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants