Skip to content

dvc: do not check for isdir on recursive out collect#3268

Merged
efiop merged 1 commit into
treeverse:masterfrom
Suor:isdir
Jan 31, 2020
Merged

dvc: do not check for isdir on recursive out collect#3268
efiop merged 1 commit into
treeverse:masterfrom
Suor:isdir

Conversation

@Suor
Copy link
Copy Markdown
Contributor

@Suor Suor commented Jan 31, 2020

The things is we create dirs as needed, so if outs are not checked out a
directory containing nothing but outs may be absent.

The things is we create dirs as needed, so if outs are not checked out a
directory contraining nothing but outs may be absent.
@Suor Suor requested a review from efiop January 31, 2020 12:54
Copy link
Copy Markdown
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks!

@efiop efiop merged commit 92bbd43 into treeverse:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants