rwlock: include actionable in error message#3270
Merged
Conversation
ghost
requested review from
shcheklein
reviewed
Jan 31, 2020
shcheklein
previously requested changes
Jan 31, 2020
Contributor
shcheklein
left a comment
shcheklein
left a comment
There was a problem hiding this comment.
please, check some comments
shcheklein
reviewed
Feb 2, 2020
Suor
previously requested changes
Feb 3, 2020
Contributor
Suor
left a comment
Suor
left a comment
There was a problem hiding this comment.
Some dedup is needed. We also have similar message in dvc.lock.
Author
|
I will handle the duplication in another pull request, as agreed on planning. |
Author
|
@efiop , I already had the patch for it, since this PR isn't closed yet, I will upload it here. |
shcheklein
reviewed
Feb 5, 2020
Suor
reviewed
Feb 6, 2020
Comment on lines
+65
to
+70
| blockers = [ | ||
| info | ||
| for path, infos in lock[mode].items() | ||
| if path_info.overlaps(path) | ||
| if info not in (infos if type(infos) is list else [infos]) | ||
| ] |
Contributor
There was a problem hiding this comment.
This logic is broken now. We create a list of info passed as param repeated 0 to several times, while in previous logic we were listing infos we've got from lock.
The right logic I guess is:
blockers = [
blocker
for path, infos in lock[mode].items()
if path_info.overlaps(path)
for blocker in (infos if isinstance(infos, list) else [infos])
if blocker != info
]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #3164