Skip to content

get/import: they don't work with any DVC project, only DVC repos (as well as Git repos)#3277

Merged
efiop merged 4 commits into
treeverse:masterfrom
jorgeorpinel:master
Feb 10, 2020
Merged

get/import: they don't work with any DVC project, only DVC repos (as well as Git repos)#3277
efiop merged 4 commits into
treeverse:masterfrom
jorgeorpinel:master

Conversation

@jorgeorpinel
Copy link
Copy Markdown
Contributor

@jorgeorpinel jorgeorpinel commented Feb 3, 2020

At least on v 0.82.6. I created a --no-scm project and tried to get and import from it to other locations, getting:

ERROR: failed to get 'data' from '/Users/drbidibombom/DVC-repos/no-scm-aux' - Failed to clone repo '/Users/drbidibombom/DVC-repos/no-scm-aux' to '/var/folders/_c/3mt_xn_d4xl2ddsx2m98h_r40000gn/T/tmpy1o07ch5dvc-clone': Cmd('git') failed due to: exit code(128)
  cmdline: git clone --no-single-branch -v /Users/drbidibombom/DVC-repos/no-scm-aux /var/folders/_c/3mt_xn_d4xl2ddsx2m98h_r40000gn/T/tmpy1o07ch5dvc-clone
  stderr: 'fatal: repository '/Users/drbidibombom/DVC-repos/no-scm-aux' does not exist
'


Having any troubles? Hit us up at https://dvc.org/support, we are always happy to help!

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

jorgeorpinel added a commit to treeverse/dvc.org that referenced this pull request Feb 3, 2020
per treeverse/dvc/pull/3277
and precursor to merging DVC repo term into DVC project (glossary)
jorgeorpinel added a commit to treeverse/dvc.org that referenced this pull request Feb 3, 2020
jorgeorpinel added a commit to treeverse/dvc.org that referenced this pull request Feb 3, 2020
Comment thread dvc/command/get.py Outdated
@jorgeorpinel
Copy link
Copy Markdown
Contributor Author

jorgeorpinel commented Feb 10, 2020

  • This is blocking jorgeorpinel/dvc/pull/1

@efiop
Copy link
Copy Markdown
Contributor

efiop commented Feb 10, 2020

Oops, sorry for the delay @jorgeorpinel !

@efiop efiop merged commit 7821fa6 into treeverse:master Feb 10, 2020
@jorgeorpinel
Copy link
Copy Markdown
Contributor Author

Ah no problem, I didn't mean to rush you @efiop, I just wanted to put a checkbox there for myself not to forget about my next PR. Thanks though!

@efiop
Copy link
Copy Markdown
Contributor

efiop commented Feb 11, 2020

@jorgeorpinel Please feel free to ping me (e.g. in PMs) if I don't respond to something in one day, I do sometimes miss/lose some notifications.

@jorgeorpinel
Copy link
Copy Markdown
Contributor Author

Thanks

efiop pushed a commit that referenced this pull request Feb 17, 2020
* get/import: update cmd and url arg descs with correct behavior

* get/import: update path arg desc as well (See previous commit)

* get/imp: udpate help output with simpler terms
per #3277 (review)

* api: url->URL in a docstring

* metrics show: update help output per
per treeverse/dvc.org#933 (review)

* diff: update `diff` and `metrics diff` help desc to match docs
per treeverse/dvc.org#933 (review)

* diff: update autocomplete scripts
per #3308 (comment)

* diff: update help output again
per treeverse/dvc.org#933 (review)

* diff/metrics diff: update help output yet again
per treeverse/dvc.org#933 (comment)

* term" under X control -> tracked by X
efiop added a commit that referenced this pull request Feb 17, 2020
* get/import: update cmd and url arg descs with correct behavior

* get/import: update path arg desc as well (See previous commit)

* get/imp: udpate help output with simpler terms
per #3277 (review)

* api: url->URL in a docstring

* metrics show: update help output per
per treeverse/dvc.org#933 (review)

* diff: update `diff` and `metrics diff` help desc to match docs
per treeverse/dvc.org#933 (review)

* diff: update autocomplete scripts
per #3308 (comment)

* diff: update help output again
per treeverse/dvc.org#933 (review)

* diff/metrics diff: update help output yet again
per treeverse/dvc.org#933 (comment)

Co-authored-by: Ruslan Kuprieiev <kupruser@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants