Conversation
Codecov Report
@@ Coverage Diff @@
## master #3288 +/- ##
==========================================
- Coverage 92.92% 92.56% -0.36%
==========================================
Files 139 139
Lines 8493 8500 +7
==========================================
- Hits 7892 7868 -24
- Misses 601 632 +31
Continue to review full report at Codecov.
|
shcheklein
approved these changes
Feb 8, 2020
Contributor
|
@Maxris Please check the tests. |
Contributor
Author
|
@efiop it seems the exceptions are related to recent changes in commit 19acded#diff-24be7b52326b428c2569724796020192 error in Travis logs - https://travis-ci.com/iterative/dvc/jobs/285154054#L17901 not sure why it fails randomly, but just restart of failed jobs helped to pass everything successfully |
Contributor
|
@Maxris Thanks for investigating! I'll take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
RemoteGDrive.removeto support gc functionality.Related to #2865