GDrive improvements and code cleanup#3294
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3294 +/- ##
=========================================
Coverage ? 92.83%
=========================================
Files ? 139
Lines ? 8541
Branches ? 0
=========================================
Hits ? 7929
Misses ? 612
Partials ? 0
Continue to review full report at Codecov.
|
Contributor
Author
|
@efiop I suggest we review codeclimate and deepsource settings a bit and make the more useful/less noisy for us. E.g. number of arguments per function - if we think that 4 is to aggressive let's increase it a bit? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a major rewrite now. It was needed since it was very hard an unproductive fixing certain issues w/o addressing some underlying problems with code.
pull- one API call per file less!Stop creating a path to the DVC remote root if it does not existcheckbox) in Google Drive support further enhancements #2865❗ Have you followed the guidelines in the Contributing to DVC list?
📖 Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.
❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏