repo: raise exception if root_dir is not a directory path#3295
Merged
Conversation
When Repo is instantiated with invalid urls such as 'http://github.com/iterative/dvc.git', it does os.path.realpath which is not intelligent enough and just concatenates with current working directory, which is then traversed outward. It might happen that the outward folder is a dvc directory which is not really what we want. So, a check for root to be a directory is added. Otherwise, NotDvcRepoError is thrown with a custom message.
efiop
reviewed
Feb 10, 2020
efiop
reviewed
Feb 10, 2020
skshetry
changed the title
pared
approved these changes
Feb 10, 2020
Contributor
pared
left a comment
pared
left a comment
There was a problem hiding this comment.
One minor thing to consider.
efiop
reviewed
Feb 10, 2020
skshetry
force-pushed
the
repo-throw-if-not-isdir
branch
from
4cbb454 to
648785d
Compare
efiop
approved these changes
Feb 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Repo is instantiated with invalid urls such as 'http://github.com/iterative/dvc.git',
it does os.path.realpath which is not intelligent enough and just concatenates with current
working directory, which is then traversed outward. It might happen that the outward folder
is a dvc directory which is not really what we want.
So, a check for root to be a directory is added. Otherwise, NotDvcRepoError is thrown with
a custom message.
TLDR:
Repo("https://github.com")andRepo("not existing directory")should throwNotDvcRepoErroreven if dvc repo exists outward.❗ Have you followed the guidelines in the Contributing to DVC list?
📖 Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.
❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏