Skip to content

ui: make progress bars respect --quiet#3316

Merged
efiop merged 5 commits into
treeverse:masterfrom
casperdcl:silent-push
Feb 14, 2020
Merged

ui: make progress bars respect --quiet#3316
efiop merged 5 commits into
treeverse:masterfrom
casperdcl:silent-push

Conversation

@casperdcl
Copy link
Copy Markdown
Contributor

@casperdcl casperdcl commented Feb 12, 2020

@casperdcl casperdcl added bug Did we break something? enhancement Enhances DVC ui user interface / interaction research labels Feb 12, 2020
@casperdcl casperdcl requested a review from efiop February 12, 2020 23:03
@casperdcl casperdcl self-assigned this Feb 12, 2020
Comment thread dvc/lock.py Outdated
@casperdcl casperdcl closed this Feb 14, 2020
@casperdcl casperdcl deleted the silent-push branch February 14, 2020 18:56
@casperdcl casperdcl restored the silent-push branch February 14, 2020 19:14
@casperdcl casperdcl reopened this Feb 14, 2020
@casperdcl
Copy link
Copy Markdown
Contributor Author

casperdcl commented Feb 14, 2020

<comment moved to separate issue #3332>

@casperdcl casperdcl added the refactoring Factoring and re-factoring label Feb 14, 2020
@casperdcl
Copy link
Copy Markdown
Contributor Author

@efiop I think this is good to merge. I don't think it's worth reverting the no_progress_bar=None changes as I intend removing most of them in a future PR (see #3332).

Comment thread dvc/remote/azure.py Outdated
@casperdcl casperdcl mentioned this pull request Feb 14, 2020
3 tasks
@casperdcl casperdcl requested a review from efiop February 14, 2020 22:04
Copy link
Copy Markdown
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@efiop efiop merged commit 276a2b0 into treeverse:master Feb 14, 2020
@casperdcl casperdcl deleted the silent-push branch February 14, 2020 23:25
@casperdcl casperdcl restored the silent-push branch February 21, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Did we break something? enhancement Enhances DVC refactoring Factoring and re-factoring research ui user interface / interaction

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dvc push -q is not completely quiet, shows file transfer tqdm progress bars

2 participants