Skip to content

daemon config fix#3324

Merged
efiop merged 1 commit into
treeverse:masterfrom
pared:daemon_fix
Feb 14, 2020
Merged

daemon config fix#3324
efiop merged 1 commit into
treeverse:masterfrom
pared:daemon_fix

Conversation

@pared
Copy link
Copy Markdown
Contributor

@pared pared commented Feb 14, 2020

  • ❗ Have you followed the guidelines in the Contributing to DVC list?

  • 📖 Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.

  • ❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

Related to #3298

@pared pared requested a review from efiop February 14, 2020 10:55
Copy link
Copy Markdown
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thank you!

@efiop efiop merged commit 0c87771 into treeverse:master Feb 14, 2020
@efiop efiop added p0-critical bug Did we break something? labels Feb 14, 2020
@pared pared deleted the daemon_fix branch March 24, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Did we break something?

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants