Skip to content

ui: fix missing progress & tidy #3335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
efiop merged 3 commits into from
Feb 19, 2020
Merged

ui: fix missing progress & tidy #3335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0724e7e
ui: show missing progress
casperdcl Feb 14, 2020
37850cb
ui: more verbose progress
casperdcl Feb 14, 2020
780f33d
remote: base: back to no_progres_bar=True
casperdcl Feb 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dvc/remote/gdrive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ def gdrive_upload_file(
self,
parent_id,
title,
no_progress_bar=True,
no_progress_bar=False,
Comment thread
casperdcl marked this conversation as resolved.
from_file="",
progress_name="",
):
Expand Down
6 changes: 3 additions & 3 deletions dvc/remote/gs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def _upload_to_bucket(
to_info,
chunk_size=None,
name=None,
no_progress_bar=True,
no_progress_bar=False,
):
blob = bucket.blob(to_info.path, chunk_size=chunk_size)
with io.open(from_file, mode="rb") as fobj:
Expand Down Expand Up @@ -166,7 +166,7 @@ def exists(self, path_info):
"""
return self.isfile(path_info) or self.isdir(path_info)

def _upload(self, from_file, to_info, name=None, no_progress_bar=True):
def _upload(self, from_file, to_info, name=None, no_progress_bar=False):
bucket = self.gs.bucket(to_info.bucket)
_upload_to_bucket(
bucket,
Expand All @@ -176,7 +176,7 @@ def _upload(self, from_file, to_info, name=None, no_progress_bar=True):
no_progress_bar=no_progress_bar,
)

def _download(self, from_info, to_file, name=None, no_progress_bar=True):
def _download(self, from_info, to_file, name=None, no_progress_bar=False):
bucket = self.gs.bucket(from_info.bucket)
blob = bucket.get_blob(from_info.path)
with io.open(to_file, mode="wb") as fobj:
Expand Down