test: check that no remote backend modules are loaded by default#3400
Merged
Conversation
Contributor
Author
|
BTW, the test should fail until #3399 lands. |
skshetry
reviewed
Feb 25, 2020
Contributor
|
@Suor could you please rebase/merge? |
Suor
force-pushed
the
remote-imports
branch
2 times, most recently
from
bf2006b to
5be238f
Compare
Contributor
Author
|
Rebased |
skshetry
approved these changes
Feb 26, 2020
pared
suggested changes
Feb 26, 2020
Contributor
Author
|
Fixed Python 3.5 |
Contributor
Author
|
Should be ready to merge. |
pared
approved these changes
Feb 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had this missed out repeatedly over time, so I added a check that we don't import any remote related deps on initial load.
Examples of related issues are #3399 and #2445.