gc: make --all-commits flag visible#3429
Merged
Merged
Conversation
Contributor
|
Btw, let's start with docs PR, stabilize it until everyone is happy with it and then we'll adjust and merge this PR. Reviews are still appreciated, but I just wanted to give this heads-up, since this is the type of issue that is heavy on the docs side, so we need to treat doc PR as the main one and this one as a complimentary one. 🙂 |
pared
approved these changes
Mar 2, 2020
Contributor
Is there a corresponding docs PR? |
jorgeorpinel
reviewed
Mar 4, 2020
Collaborator
Author
|
Hey, @jorgeorpinel, can you take a quick look? |
jorgeorpinel
approved these changes
Mar 9, 2020
Contributor
jorgeorpinel
left a comment
jorgeorpinel
left a comment
There was a problem hiding this comment.
Looks good, thanks @skshetry
Is there a matching docs PR?
Collaborator
Author
|
@jorgeorpinel, this should be in treeverse/dvc.org#1023. |
9 tasks
casperdcl
added a commit
to casperdcl/dvc
that referenced
this pull request
Mar 10, 2020
Due to treeverse#3429 superceding treeverse#2681
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing #2325
❗ Have you followed the guidelines in the Contributing to DVC list?
📖 Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.
❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏