external_repo: do not try too hard to fix upstream#3512
Merged
Conversation
skshetry
changed the title
skshetry
commented
Mar 19, 2020
efiop
reviewed
Mar 19, 2020
efiop
reviewed
Mar 19, 2020
skshetry
commented
Mar 20, 2020
Comment on lines
127
to
128
| if not os.path.isdir(self.url): | ||
| return |
Collaborator
Author
There was a problem hiding this comment.
This check is redundant here as it should be covered by below try/except block. But, I think, this makes the intention clearer, so, keeping it for now. :)
efiop
approved these changes
Mar 20, 2020
Contributor
|
Thank you @skshetry ! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.
❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
This is a good-enough fix for #3451. At the moment, local remote does not work at all and treats it like how it'd be if it was a remote dvc repo. It's not clear if we should support this at all (ref: #2756, #3378)
Fix #3451.