Skip to content

introduce hyper parameters and config#3515

Merged
efiop merged 11 commits into
treeverse:masterfrom
elgehelge:#3393-Introduce-hyper-parameters-and-config
Mar 24, 2020
Merged

introduce hyper parameters and config#3515
efiop merged 11 commits into
treeverse:masterfrom
elgehelge:#3393-Introduce-hyper-parameters-and-config

Conversation

@elgehelge
Copy link
Copy Markdown
Contributor

@elgehelge elgehelge commented Mar 19, 2020

Part of #3393

@efiop efiop changed the title #3393 introduce hyper parameters and config [WIP] #3393 introduce hyper parameters and config Mar 19, 2020
@efiop efiop changed the title [WIP] #3393 introduce hyper parameters and config [WIP] introduce hyper parameters and config Mar 19, 2020
@efiop efiop force-pushed the #3393-Introduce-hyper-parameters-and-config branch 4 times, most recently from 540a634 to b10a868 Compare March 24, 2020 02:04
@dmpetrov
Copy link
Copy Markdown
Contributor

I did some basic testing. It looks really good! Thank you @elgehelge and @efiop!

Some issues that I was able to find:

  1. Params list formatting should be human-readable like Parameter lr1, dropout are missing ...
$ dvc run -p lr1 -M metrics.json -f Dvcfile python train.py
Running command:
	python train.py
ERROR: failed to run command - Parameters '{'lr1'}' are missing from 'params.yaml'.
  1. How to define nested params train.lr?
$ cat params.yaml
train:
    lr: 0.0041
    layers: 9
    dropout: 0.21

processing:
    th: 0.98
    bow: 7000

$ dvc run -p train.lr -M metrics.json -f Dvcfile python train.py
Running command:
	python train.py
ERROR: failed to run command - Parameters '{'train.lr'}' are missing from 'params.yaml'.
  1. Can I redefine the params file name (or not in this change)?

@efiop efiop force-pushed the #3393-Introduce-hyper-parameters-and-config branch from b10a868 to b887430 Compare March 24, 2020 13:50
@efiop
Copy link
Copy Markdown
Contributor

efiop commented Mar 24, 2020

Params list formatting should be human-readable like Parameter lr1, dropout are missing

Formatting issue, fixed.

How to define nested params train.lr?

Added support for basic a.b.c params support. Wildcards and more advanced things will be introduced later.

Can I redefine the params file name (or not in this change)?

Yes, -p path/to/params:param1,param2.

@efiop efiop changed the title [WIP] introduce hyper parameters and config introduce hyper parameters and config Mar 24, 2020
@efiop efiop force-pushed the #3393-Introduce-hyper-parameters-and-config branch from b887430 to 4ec0267 Compare March 24, 2020 15:29
@efiop efiop merged commit 28748ff into treeverse:master Mar 24, 2020
@efiop
Copy link
Copy Markdown
Contributor

efiop commented Mar 24, 2020

Thank you @elgehelge ! 🙏

@shcheklein
Copy link
Copy Markdown
Contributor

@elgehelge @efiop do we have docs coming for this?

@efiop
Copy link
Copy Markdown
Contributor

efiop commented Mar 25, 2020

@shcheklein Not yet, this was just the first step. Docs will be later.

@dmpetrov dmpetrov mentioned this pull request Mar 25, 2020
@jorgeorpinel
Copy link
Copy Markdown
Contributor

Hi. So this is a hidden feature for now?

@efiop
Copy link
Copy Markdown
Contributor

efiop commented Mar 26, 2020

@jorgeorpinel Just unfinished and undocumented on dvc.org. Not hidden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants