Metrics - plotting for multiple revisions initial#3577
Merged
Conversation
pared
force-pushed
the
3409_diff
branch
3 times, most recently
from
76a42af to
25f606b
Compare
pared
force-pushed
the
3409_diff
branch
3 times, most recently
from
33abe3e to
d06056b
Compare
pared
changed the title
pmrowla
reviewed
Apr 13, 2020
Contributor
pmrowla
left a comment
pmrowla
left a comment
There was a problem hiding this comment.
Looks good for the most part, just had the one question about the 3.5 test issue
pmrowla
reviewed
Apr 14, 2020
efiop
reviewed
Apr 14, 2020
efiop
reviewed
Apr 14, 2020
efiop
reviewed
Apr 14, 2020
efiop
reviewed
Apr 14, 2020
efiop
reviewed
Apr 14, 2020
efiop
reviewed
Apr 14, 2020
efiop
reviewed
Apr 14, 2020
efiop
reviewed
Apr 14, 2020
pared
force-pushed
the
3409_diff
branch
3 times, most recently
from
9631e90 to
890a0ef
Compare
shcheklein
reviewed
Apr 27, 2020
Contributor
efiop
reviewed
Apr 30, 2020
efiop
reviewed
Apr 30, 2020
efiop
reviewed
Apr 30, 2020
efiop
reviewed
Apr 30, 2020
efiop
reviewed
Apr 30, 2020
efiop
reviewed
Apr 30, 2020
Co-authored-by: Ruslan Kuprieiev <kupruser@gmail.com>
Co-authored-by: Ruslan Kuprieiev <kupruser@gmail.com>
jorgeorpinel
reviewed
May 6, 2020
jorgeorpinel
reviewed
May 6, 2020
| "--template", | ||
| nargs="?", | ||
| default=None, | ||
| help="File to be injected with data.", |
Contributor
There was a problem hiding this comment.
Maybe link to some doc where we explain templates? Something like
help="Vega specification template file to inject with the data. See man.dvc.org/...",
See conversation in #3577 (comment)
jorgeorpinel
reviewed
May 6, 2020
Contributor
There was a problem hiding this comment.
A few post-merge ideas and questions @pared ☝️
Also possibly pending, #3577 (comment)
I can send a PR but if you could answer my questions when you can, that'll help me.
2 tasks
Closed
jorgeorpinel
added a commit
that referenced
this pull request
May 7, 2020
efiop
pushed a commit
that referenced
this pull request
May 12, 2020
* plot: update datafile desc. * plot: link to cmd ref in output * plot: update --stdout desc per #3577 (review) * plot: a few more output string updates per #3759 (review) and treeverse/dvc.org#1283
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.
❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Next stage of #3569