output: use strings instead of PathInfo for performance reasons#3663
Conversation
|
The optimization in There are still several places we can improve in @efiop, should I continue with this or do we want to just leave it at only the used_dir_cache change for now? |
|
@pmrowla Your call. I would be perfectly happy to merge this first though. Astonishing results! |
|
@pmrowla About checksum_to_path_info. We used to have |
|
@efiop in that case, once I fix whatever is failing CI in windows I'll mark this PR as reviewable/mergeable. We can leave the original issue open and I'll keep looking into optimizing checksum_to_path_info |
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.
❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Partial fix for #3635.