Skip to content

Snap version#3741

Merged
efiop merged 2 commits into
treeverse:masterfrom
casperdcl:snap-version
May 5, 2020
Merged

Snap version#3741
efiop merged 2 commits into
treeverse:masterfrom
casperdcl:snap-version

Conversation

@casperdcl
Copy link
Copy Markdown
Contributor

  • fix snapcraft on travis CI missing version tags

@casperdcl casperdcl self-assigned this May 4, 2020
@casperdcl
Copy link
Copy Markdown
Contributor Author

@efiop looks like the snap builds started working again miraculously but probably safest to still merge this PR in case it happens again.

Comment thread .travis.yml
- sudo /snap/bin/lxd.migrate -yes
- sudo /snap/bin/lxd waitready
- sudo /snap/bin/lxd init --auto
- git fetch --tags
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snap was failing on master and PR builds. Not sure how this is related.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think travis was failing in some cases to pull tags, so git describe was failing, meaning snapcraft couldn't get a version.

@efiop efiop merged commit 795f001 into treeverse:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants