Skip to content

Drop Python 3.5 support#3792

Merged
efiop merged 6 commits into
treeverse:masterfrom
pmrowla:3765-drop-py35
May 13, 2020
Merged

Drop Python 3.5 support#3792
efiop merged 6 commits into
treeverse:masterfrom
pmrowla:3765-drop-py35

Conversation

@pmrowla
Copy link
Copy Markdown
Contributor

@pmrowla pmrowla commented May 13, 2020

Will close #3765.
Docs PR treeverse/dvc.org/pull/1287

  • ❗ I have followed the Contributing to DVC checklist.

  • 📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.

  • ❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

Tasks:

  • Drop 3.5 from PyPI supported version list
  • Drop 3.5 CI builds
  • Remove dvc.compat.fspath/dvc.compat.fspath_py35 in favor of os.fspath
  • Remove unneeded fspath(path_info) wrappers inside os/os.path function calls

Things not addressed in this PR:

  • os.path...(path_info) calls will not be replaced with PurePath equivalents (i.e. os.path.exists(path_info) still used rather than path_info.exists())

Copy link
Copy Markdown
Contributor

@pared pared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, since python3.6 dict keeps the order of inserted elements, so I think we could try to get rid of OrderedDict usages. I don't know about other use cases, but in case of dvc plot py3.5 was the only reason to implement yaml, csv and json specific data loaders utilizing OrderedDict. We can create separate task for that, as it might invlove some logic removal (eg mentioned specialized loaders).

@pared
Copy link
Copy Markdown
Contributor

pared commented May 13, 2020

I searched a bit on dict thing:
https://docs.python.org/3.6/whatsnew/3.6.html#other-language-changes

The order-preserving aspect of this new implementation is considered an implementation detail and should not be relied upon

So maybe we should leave the OrderedDict in the end.

@pmrowla pmrowla changed the title [WIP] Drop Python 3.5 support Drop Python 3.5 support May 13, 2020
@efiop
Copy link
Copy Markdown
Contributor

efiop commented May 13, 2020

image

@efiop efiop merged commit 833e82a into treeverse:master May 13, 2020
@pmrowla pmrowla deleted the 3765-drop-py35 branch May 14, 2020 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop python 3.5 support?

3 participants