Add plots props and plots modify params#3911
Merged
Merged
Conversation
Contributor
Author
|
There is no tests for new |
skshetry
reviewed
May 29, 2020
efiop
reviewed
May 29, 2020
Co-authored-by: Ruslan Kuprieiev <kupruser@gmail.com>
efiop
reviewed
May 29, 2020
efiop
reviewed
May 29, 2020
efiop
reviewed
May 29, 2020
efiop
reviewed
May 29, 2020
Co-authored-by: Ruslan Kuprieiev <kupruser@gmail.com>
Co-authored-by: Ruslan Kuprieiev <kupruser@gmail.com>
Co-authored-by: Ruslan Kuprieiev <kupruser@gmail.com>
Co-authored-by: Ruslan Kuprieiev <kupruser@gmail.com>
Contributor
|
Looks good! Let's merge and work on top. Thanks @Suor ! 🙏 |
3 tasks
Closed
jorgeorpinel
reviewed
Jun 6, 2020
| _add_output_arguments(plots_diff_parser) | ||
| plots_diff_parser.set_defaults(func=CmdPlotsDiff) | ||
|
|
||
| PLOTS_MODIFY_HELP = "Modify plot props associated with a target file." |
Contributor
There was a problem hiding this comment.
Can we call them "plot display properties" or at least "properties" in user-facing strings please? 🙂
Lmk if so to change it in treeverse/dvc.org/pull/1382 while it's in progress, to avoid requiring another docs PR for such change.
Contributor
There was a problem hiding this comment.
Thanks, updated docs PR too.
Contributor
|
@Suor Could you take a look at this one too, please? |
efiop
pushed a commit
to efiop/dvc
that referenced
this pull request
Jun 8, 2020
efiop
added a commit
that referenced
this pull request
Jun 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Along the way:
dvc plots diffnow workxvsx_field,xlabandx_title)NOTE: several plots per plot data file not supported here. There are at least two design decisions need to be made: how do they interact with
dvc plots add/modify/deleteand how do we collect them when they are inconsistent.Collecting inconsistent props from different revisions for now solved by using props from first rev mentioned and issuing a warning.