Unify metrics behavior with dirs#3935
Merged
Merged
Conversation
efiop
reviewed
Jun 2, 2020
Comment on lines
+259
to
+261
| if self.metric: | ||
| self.verify_metric() | ||
|
|
Contributor
There was a problem hiding this comment.
There is a
if self.metric or self.plot:
self.verify_metric()
a few lines above, under if not self.use_cache. How about we just move it outside of that if and check before that?
4 tasks
Contributor
|
For the record: partial fix for #3924 |
Contributor
|
Looks great! One more thing: could you please add a test for it? |
Contributor
Author
|
@efiop , should I fix latest DeepSource issues too? BTW it seems that PyTest preferred over the UnitTest and all the future tests should be implemented via PyTests. Is it correct? |
Contributor
Yes, this is correct |
Contributor
efiop
pushed a commit
that referenced
this pull request
Jun 5, 2020
* change DvcParser to print subcommand help * add tests for subcommand help * docstring refactoring * remote: finish separating RemoteTree methods (#3946) * remote: move upload()/download() into tree * remote: move path_info/path_cls into tree * remote.azure: finish moving methods into tree * remote.gs: finish moving methods into tree * remote.hdfs: finish moving methods to tree * remote.http: finish moving methods into tree * remote.oss: finish moving methods into tree * remote.s3: finish moving methods into tree * remote.ssh: finish moving methods into tree * remote.gdrive: finish moving methods into tree * tests: update remote unit tests * tests: update func tests * remote: use walk_files() for all remotes * list_cache_paths() now uses tree.walk_files() for all remotes except local/ssh * fix DS warnings * bugfixes * Unify metrics behavior with dirs (#3935) * run: disable directories for -m/-M flags * run: reformatted string literals * run: simplified metrics check * tests: func: run: dirs as metrics outs * tests: func: run: reformatted string literals * tests: use pytest Co-authored-by: Ruslan Kuprieiev <ruslan@iterative.ai> * refactor/test multistage load for params and outputs (#3949) * refactor multistage load for params and outputs * tests: load params * tests: output loading from pipeline file * fix test * fix typo in name * split params load * rename params func s/inject_values/fill_values * fix tests * simplify loads_params and output.load_from_pipeline * address @pared's suggestions for tests * remote: fix build errors (#3957) * remote: fix remaining gdrive build issues (#3959) * tests: fix gdrive build * remote.gdrive: fix walk_files prefix relpath * change DvcParser to print subcommand help * add tests for subcommand help * docstring refactoring * change tests to pytest-style * remove gettext Co-authored-by: Peter Rowlands (변기호) <peter@pmrowla.com> Co-authored-by: nik123 <kodenkonikita@gmail.com> Co-authored-by: Ruslan Kuprieiev <ruslan@iterative.ai> Co-authored-by: Saugat Pachhai <suagatchhetri@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3930