Skip to content

plots: fix error when there are no plots in repo#3940

Merged
efiop merged 1 commit into
treeverse:masterfrom
efiop:fix-3925
Jun 3, 2020
Merged

plots: fix error when there are no plots in repo#3940
efiop merged 1 commit into
treeverse:masterfrom
efiop:fix-3925

Conversation

@efiop
Copy link
Copy Markdown
Contributor

@efiop efiop commented Jun 2, 2020

Consistent with dvc metrics show/diff behaviour.

Fixes #3925

  • ❗ I have followed the Contributing to DVC checklist.

  • 📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.

  • ❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

@efiop efiop requested review from Suor and jorgeorpinel June 2, 2020 22:42
Comment thread dvc/exceptions.py Outdated
Comment thread tests/func/plots/test_plots.py Outdated
Consistent with `dvc metrics show/diff` behaviour.

Fixes treeverse#3925
@Suor
Copy link
Copy Markdown
Contributor

Suor commented Jun 3, 2020

Ok, maybe I will have time this week to get rid of those exceptions.

@efiop efiop merged commit ff54ac1 into treeverse:master Jun 3, 2020
@efiop efiop deleted the fix-3925 branch June 3, 2020 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

plots show: targets are required but help output indicates otherwise [qa]

2 participants