Skip to content

remote: fix remaining gdrive build issues #3959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pmrowla merged 2 commits into from
Jun 5, 2020
Merged

remote: fix remaining gdrive build issues #3959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
affa058
tests: fix gdrive build
pmrowla Jun 5, 2020
6111ffe
remote.gdrive: fix walk_files prefix relpath
pmrowla Jun 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions dvc/remote/gdrive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,8 +537,9 @@ def walk_files(self, path_info, **kwargs):
if path_info == self.path_info:
prefix = None
else:
prefix = path_info.relative_to(self.path_info).path
return self._list_paths(prefix=prefix, **kwargs)
prefix = path_info.path
for fname in self._list_paths(prefix=prefix, **kwargs):
yield path_info.replace(fname)

def remove(self, path_info):
item_id = self._get_item_id(path_info)
Expand Down
2 changes: 1 addition & 1 deletion tests/remotes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ def create_dir(dvc, url):
"gdrive_use_service_account": True,
}
remote = GDriveRemote(dvc, config)
remote._gdrive_create_dir("root", remote.path_info.path)
remote.tree._gdrive_create_dir("root", remote.path_info.path)

@staticmethod
def get_url():
Expand Down