Skip to content

add/run/import-url: don't use -f as --file#4004

Merged
efiop merged 1 commit into
treeverse:masterfrom
efiop:file_force
Jun 10, 2020
Merged

add/run/import-url: don't use -f as --file#4004
efiop merged 1 commit into
treeverse:masterfrom
efiop:file_force

Conversation

@efiop
Copy link
Copy Markdown
Contributor

@efiop efiop commented Jun 10, 2020

If anything, -f is closer to --force than to --file. So let's set
this straight.

treeverse/dvc.org#1255 treeverse/dvc.org/issues/1426

  • ❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

If anything, `-f` is closer to `--force` than to `--file`. So let's set
this straight.
@efiop efiop added this to the 1.0 milestone Jun 10, 2020
@efiop efiop merged commit 91a7194 into treeverse:master Jun 10, 2020
@efiop efiop deleted the file_force branch June 10, 2020 02:05
@jorgeorpinel
Copy link
Copy Markdown
Contributor

jorgeorpinel commented Jun 11, 2020

Hi. I see a checkbox was added for this in treeverse/dvc.org/issues/1255, thanks. But that's not really a catch all epic for every change from now on 😋

I may be wrong but this doesn't sound like a 1.0-specific change to me, can we open a separate docs issue or PR instead, please?

@efiop
Copy link
Copy Markdown
Contributor Author

efiop commented Jun 11, 2020

@jorgeorpinel it is used all over the docs and I have no idea what to change there because of all of the 1.0 conflicting PRs hanging that affect all of the docs that I need to change. So I've added it to the epic.

@jorgeorpinel
Copy link
Copy Markdown
Contributor

Please open an issue and link to the core PR when submitting a PR is not possible. That's totally fine. Done: treeverse/dvc.org/issues/1426

@efiop
Copy link
Copy Markdown
Contributor Author

efiop commented Jun 12, 2020

@jorgeorpinel It was added to the epic get rid of -f in add/run/import(-url) per iterative/dvc#4004 and iterative/dvc#4011, you can see it in the history of changes, but you've deleted it in the past two days.

@jorgeorpinel
Copy link
Copy Markdown
Contributor

I extracted it into treeverse/dvc.org#1426 like I just mentioned. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants