(bugfix) get/import: fix broken progress bar#4039
Merged
Merged
Conversation
PR treeverse#3672 (6d8499e) extended `LocalRemote::_get_plans` to return one `checksums` too. As all of the args from `_get_plans` was passed down to `download()`, it recognized extra arg of checksum as `no_progress_bar` due to which it became True and stopped showing progress bar at all. Fix treeverse#3874
skshetry
commented
Jun 14, 2020
| fails = sum( | ||
| executor.map(func, from_infos, to_infos, names) | ||
| ) | ||
| else: |
Collaborator
Author
There was a problem hiding this comment.
_get_plans returns four values (previously 3, with the new one being checksum).
https://github.com/iterative/dvc/blob/4d140a99445cbdcdf020b43551dc2aee9f970686/dvc/remote/local.py#L577
This checksum was received by download as no_progress_bar args.
https://github.com/iterative/dvc/blob/4d140a99445cbdcdf020b43551dc2aee9f970686/dvc/remote/base.py#L330-L338
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3672 (6d8499e) extended
LocalRemote::_get_plansto returnchecksums. As all of the args from_get_planswas passeddown to
download(), it recognized extra arg of checksum asno_progress_bardue to which it became True and stopped showingprogress bar at all.
Fix #3874
Screenshots
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.
❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)
Thank you for the contribution - we'll try to review it as soon as possible. 🙏