get-url/import-url: save dependency before downloading#4049
Merged
Conversation
This allows us to properly process the errors like missing target. Fixes treeverse#3897
skshetry
approved these changes
Jun 16, 2020
skshetry
reviewed
Jun 16, 2020
| # then we have #2059 bug and can't really handle that. | ||
| p = self.TREE_CLS.PATH_CLS(path) | ||
| if not p.is_absolute(): | ||
| if self.stage and not p.is_absolute(): |
Collaborator
There was a problem hiding this comment.
We should probably remove the dependency on stage, this is very much circular: stage needs outs/deps, and outs/deps require stages, so, when we construct a stage, there's no way beforehand to create outs/deps without creating a stage first without any deps/outs.
Contributor
Author
There was a problem hiding this comment.
@skshetry you mean from the outputs/deps themselves? We still use it in some places, so easier said than done. Logically outs and deps do belong to the stage, but the way we create and fill them is not very friendly, I agree.
Collaborator
There was a problem hiding this comment.
What I am trying to say is, Output should not get access to the Stage at all. We could pass wdir and repo if they need it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to properly process the errors like missing target.
Fixes #3897
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.
❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)
Thank you for the contribution - we'll try to review it as soon as possible. 🙏