Skip to content

optimize: remove fsync when dumping rwlock data #4052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
efiop merged 1 commit into from
Jun 16, 2020
Merged

optimize: remove fsync when dumping rwlock data #4052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions dvc/rwlock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,6 @@ def _edit_rwlock(lock_dir):
yield lock
with open(path, "w+") as fobj:
json.dump(lock, fobj)
# NOTE: flush and fsync to ensure that rwlock contents are saved
fobj.flush()
os.fsync(fobj.fileno())


def _infos_to_str(infos):
Expand Down
2 changes: 1 addition & 1 deletion tests/func/test_repro_multistage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,7 @@ def test_repro_when_new_outs_added_does_not_exist(tmp_dir, dvc):
{
"stages": {
"run-copy": {
"cmd": "python copy {} {}".format("foo", "foobar"),
"cmd": "python copy.py {} {}".format("foo", "foobar"),
Copy link
Copy Markdown
Collaborator Author

@skshetry skshetry Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snakeoil tests, don't know how this was even passing.

"deps": ["foo"],
"outs": ["foobar", "bar"],
}
Expand Down