Skip to content

remove: clean gitignore content#4074

Merged
efiop merged 3 commits into
treeverse:masterfrom
nik123:CleanGitignoreAfterRemove
Jun 19, 2020
Merged

remove: clean gitignore content#4074
efiop merged 3 commits into
treeverse:masterfrom
nik123:CleanGitignoreAfterRemove

Conversation

@nik123
Copy link
Copy Markdown
Contributor

@nik123 nik123 commented Jun 19, 2020

Fixes #4013

PR doesn't require documentation updates

Comment thread dvc/output/base.py
Comment thread dvc/output/base.py Outdated
Co-authored-by: Ruslan Kuprieiev <kupruser@gmail.com>
Copy link
Copy Markdown
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @nik123 ! 🙏

@efiop efiop merged commit 5d97f92 into treeverse:master Jun 19, 2020
@nik123 nik123 deleted the CleanGitignoreAfterRemove branch June 19, 2020 16:45
@jorgeorpinel
Copy link
Copy Markdown
Contributor

jorgeorpinel commented Jun 23, 2020

PR doesn't require documentation updates

This could be noted in https://dvc.org/doc/command-reference/remove. Instead of "removes all of its outputs (outs field), and optionally...":

"deletes all of its output files or directories (outs field), removes them from .gitignore, and optionally..."

Maybe even the examples should show this and include git add/remove and commit to indicate how to save the change to the repo.

@jorgeorpinel
Copy link
Copy Markdown
Contributor

jorgeorpinel commented Jun 23, 2020

p.s. unrelated question on remove @efiop: If this is the only stage in dvc.yaml does dvc.yaml remain empty, or does it get removed? (along with dvc.lock). Thanks

@nik123
Copy link
Copy Markdown
Contributor Author

nik123 commented Jun 23, 2020

This could be noted in https://dvc.org/doc/command-reference/remove. Instead of "removes all of its outputs (outs field), and optionally...":

"deletes all of its output files or directories (outs field), removes them from .gitignore, and optionally..."

@jorgeorpinel should description for dvc remove -h be updated as well? If so, what should go first - updates in core repo or in documentation?

@efiop
Copy link
Copy Markdown
Contributor

efiop commented Jun 23, 2020

p.s. unrelated question on remove @efiop: If this is the only stage in dvc.yaml does dvc.yaml remain empty, or does it get removed? (along with dvc.lock). Thanks

It is the easiest to just try that and see :) But yes, both remain empty. Could clean that up a bit, for sure. Created #4090 Thanks for the heads up!

@efiop
Copy link
Copy Markdown
Contributor

efiop commented Jun 23, 2020

l should description for dvc remove -h be updated as well? If so, what should go first - updates in core repo or in documentation?

@nik123 Could start with core repo. Thanks! 🙏

@nik123
Copy link
Copy Markdown
Contributor Author

nik123 commented Jun 23, 2020

@efiop , @jorgeorpinel : I checked cmd ref and ran into other problems which I think should be addressed before .gitignore. For details see #4094

@jorgeorpinel
Copy link
Copy Markdown
Contributor

should description for dvc remove -h be updated as well?
checked cmd ref and ran into other problems

@nik123 thanks! Yes, if the core repo needs an update to the help output that would come first, and then update everything on the docs side 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dvc remove'd folder stays in gitignore

3 participants