Skip to content

metrics: skip missing metrics silently#4130

Merged
efiop merged 1 commit into
treeverse:masterfrom
Suor:missing-metric-files
Jun 29, 2020
Merged

metrics: skip missing metrics silently#4130
efiop merged 1 commit into
treeverse:masterfrom
Suor:missing-metric-files

Conversation

@Suor
Copy link
Copy Markdown
Contributor

@Suor Suor commented Jun 29, 2020

Reverts an issue caused by #4005.

@Suor Suor requested a review from efiop June 29, 2020 13:48
@efiop efiop added bug Did we break something? p0-critical labels Jun 29, 2020
Comment thread tests/func/metrics/test_show.py Outdated
Comment on lines 108 to 109
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests failed on windows. Use remove from dvc.utils.

@Suor Suor force-pushed the missing-metric-files branch from ed8e59e to cc1d2cb Compare June 29, 2020 14:33
@efiop efiop merged commit a7e825a into treeverse:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Did we break something?

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants