S3: Use key_id and key_secret directly#4224
Conversation
|
Hi @farizrahman4u ! Thank you for the PR! Please take a look at our contribution guide (it was in the PR hints). Right now our patch checks are failing, because you didn't have pre-commit hooks installed. 🙂 |
|
Also, please feel free to mark your PR as WIP/draft if it is not ready for review yet 🙂 Thanks! |
|
@efiop CI seems to be cloning the main repo instead of the fork? |
|
Looks like it is trying to run restyled's PR and is failing as the branch is no longer there. |
|
@efiop Done. |
Co-authored-by: Ruslan Kuprieiev <kupruser@gmail.com>
|
Btw, @farizrahman4u , in the PR header that you've removed, there was a bulletpoint about docs. In particular, we need to add the new config options to https://dvc.org/doc/command-reference/remote/modify (there is an edit button). Could you please submit a docs PR after we are done with config option naming here? 🙂 |
|
@efiop done renames and docs pr : treeverse/dvc.org#1589 |
| self.access_key_id = config.get("access_key_id") | ||
| self.secret_access_key = config.get("secret_access_key") |
There was a problem hiding this comment.
Why do we assign it instead of using self.config directly later?
There was a problem hiding this comment.
Following the pattern in other remotes (OSS, GDrive etc).
efiop
left a comment
efiop
left a comment
There was a problem hiding this comment.
Thank you @farizrahman4u !
5 participants
Fixes #4175
@efiop