Optimize dvcignore#4242
Merged
Merged
Conversation
karajan1001
commented
Jul 19, 2020
efiop
pushed a commit
to efiop/dvc
that referenced
this pull request
Jul 19, 2020
Continuing treeverse#4050 This issue was found in treeverse#4242
3 tasks
Contributor
|
For the record: that strange bug with the number of calls of file_md5 was caused by #4244 . Please rebase and it will go away 🙂 |
efiop
added a commit
that referenced
this pull request
Jul 19, 2020
pared
suggested changes
Jul 20, 2020
Contributor
Author
|
Contributor
|
@karajan1001 when is it showing up? Running tests? |
Contributor
Author
|
@pared |
pared
approved these changes
Jul 21, 2020
Contributor
|
@karajan1001 |
Contributor
Author
|
Excuse me, how can I restart build myself? |
Contributor
|
@karajan1001 |
Contributor
|
test failures are unrelated. Thank you! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
optimize #3869
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)
Thank you for the contribution - we'll try to review it as soon as possible. 🙏