daemon: don't use Popen on linux/mac#4262
Merged
Merged
Conversation
We used `Popen` just to provide a general way of launching our daemons on both Windows and *nix, but it is causing us issues when dvc is launched from some exotic places (like nix package) or through `main()` helper from a script that is not dvc. This patch makes us just use `main()` directly in our double-forked process. Windows implementation has to use the `Popen` mechanism, because this is the only way to daemonize a process on Windows. This means that dvc on Windows is still susceptible to this problem, but there is nothing we can do about it right now :( Fixes treeverse#4206 Fixes treeverse#4165
pared
approved these changes
Jul 23, 2020
Contributor
pared
left a comment
pared
left a comment
There was a problem hiding this comment.
Build fails, seems like something with PyInstaller
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used
Popenjust to provide a general way of launching our daemonson both Windows and *nix, but it is causing us issues when dvc is
launched from some exotic places (like nix package) or through
main()helper from a script that is not dvc.
This patch makes us just use
main()directly in our double-forkedprocess.
Windows implementation has to use the
Popenmechanism, because this isthe only way to daemonize a process on Windows. This means that dvc on
Windows is still susceptible to this problem, but there is nothing we
can do about it right now :(
Fixes #4206
Fixes #4165
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)
Thank you for the contribution - we'll try to review it as soon as possible. 🙏