repro: update status message for dvc-added files#4269
Closed
sarthakforwet wants to merge 1 commit into
Closed
Conversation
efiop
suggested changes
Jul 23, 2020
Contributor
efiop
left a comment
efiop
left a comment
There was a problem hiding this comment.
Thanks for the PR! Please check our contributing guide https://dvc.org/doc/user-guide/contributing/core (it was in the PR header that you've removed). You need to install pre-commit hooks and run those.
efiop
reviewed
Jul 23, 2020
| def reproduce(self, interactive=False, **kwargs): | ||
| if not (kwargs.get("force", False) or self.changed()): | ||
| logger.info("Stage '%s' didn't change, skipping", self.addressing) | ||
| if '.dvc' in self.adressing: |
Contributor
There was a problem hiding this comment.
As I've mentioned in #4233 (comment) , using .dvc suffix is not the best approach:
Suggested change
| if '.dvc' in self.adressing: | |
| if not isinstance(stage, PipelineStage) and stage.is_data_source: |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason for updating the status message is that
.dvcfiles are not stages and hence we can just remove the prefix "Stage" from the output whenever a.dvcfile would be detected.References #4233