Skip to content

[WIP] Dynamic subrepo collection#4299

Closed
skshetry wants to merge 12 commits into
treeverse:masterfrom
skshetry:subrepo-support-2
Closed

[WIP] Dynamic subrepo collection#4299
skshetry wants to merge 12 commits into
treeverse:masterfrom
skshetry:subrepo-support-2

Conversation

@skshetry
Copy link
Copy Markdown
Collaborator

See 3a46641

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

@efiop
Copy link
Copy Markdown
Contributor

efiop commented Jul 29, 2020

Seems like this get's more and more convoluted. I would suggest taking a step back and going with smaller iterative PRs that we can merge faster. For example, first one could be to collect subrepos and use that in dvcignores.

@skshetry
Copy link
Copy Markdown
Collaborator Author

skshetry commented Aug 3, 2020

Closing, will try creating smaller PRs.

@skshetry skshetry deleted the subrepo-support-2 branch August 19, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants