Skip to content

Exclude pylint==6.0 #4300

Merged
skshetry merged 1 commit into
masterfrom
skshetry-patch-1
Jul 29, 2020
Merged

Exclude pylint==6.0 #4300
skshetry merged 1 commit into
masterfrom
skshetry-patch-1

Conversation

@skshetry
Copy link
Copy Markdown
Collaborator

pytest-dev/pytest#7558
pylint throws error for pytest.mark.* functions in pytest6.

tests/unit/repo/test_repo.py:15:1: E1102: pytest.mark.parametrize is not callable (not-callable)
tests/unit/repo/test_repo.py:33:1: E1102: pytest.mark.parametrize is not callable (not-callable)
************* Module tests.unit.remote.ssh.test_connection
tests/unit/remote/ssh/test_connection.py:87:1: E1102: pytest.mark.skipif is not callable (not-callable)
tests/unit/remote/ssh/test_connection.py:100:1: E1102: pytest.mark.skipif is not callable (not-callable)

#4257 (comment)

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

pytest-dev/pytest#7558
pylint throws error for `pytest.mark.*` functions in pytest6.

```
tests/unit/repo/test_repo.py:15:1: E1102: pytest.mark.parametrize is not callable (not-callable)
tests/unit/repo/test_repo.py:33:1: E1102: pytest.mark.parametrize is not callable (not-callable)
************* Module tests.unit.remote.ssh.test_connection
tests/unit/remote/ssh/test_connection.py:87:1: E1102: pytest.mark.skipif is not callable (not-callable)
tests/unit/remote/ssh/test_connection.py:100:1: E1102: pytest.mark.skipif is not callable (not-callable)
```
#4257 (comment)
@skshetry skshetry added the build label Jul 29, 2020
@skshetry skshetry self-assigned this Jul 29, 2020
@skshetry
Copy link
Copy Markdown
Collaborator Author

We need to fix our dependencies for the tests, and auto-update them with dependabot.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 29, 2020

Codecov Report

Merging #4300 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4300   +/-   ##
=======================================
  Coverage   91.65%   91.65%           
=======================================
  Files         173      173           
  Lines       11776    11776           
=======================================
  Hits        10793    10793           
  Misses        983      983           
Impacted Files Coverage Δ
dvc/version.py 83.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31efaac...abf6943. Read the comment docs.

@skshetry skshetry merged commit 9ca3c05 into master Jul 29, 2020
@delete-merged-branch delete-merged-branch Bot deleted the skshetry-patch-1 branch July 29, 2020 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant