commit: make sure deps/outs exist#4305
Merged
Merged
Conversation
efiop
commented
Jul 30, 2020
Comment on lines
70
to
73
Contributor
Author
There was a problem hiding this comment.
This status hack backfired a bit. Need to set self.tree properly here (it will pretty much be RepoTree for the external repo that this belongs to), so that things like self.exists() work automatically.
efiop
commented
Jul 30, 2020
| self.info = self.save_info() | ||
|
|
||
| def commit(self): | ||
| assert self.info |
Contributor
Author
There was a problem hiding this comment.
Added this because https://github.com/iterative/dvc/blob/2f48bb4089c25c2144fa3c9d9d8d0ba69c4c3e51/dvc/cache/base.py#L280 shouldn't be there, really. It is a leftover from erepo/tree hacks we used to have, but some code is still using it, so need to get back to it in a separate PR.
pmrowla
approved these changes
Jul 30, 2020
efiop
pushed a commit
to efiop/dvc
that referenced
this pull request
Jul 31, 2020
This is incorrect and leads to weird bugs like treeverse#4305
efiop
added a commit
that referenced
this pull request
Jul 31, 2020
* cache: don't make save() compute the hash This is incorrect and leads to weird bugs like #4305 * tree: get rid of explicit tree arguments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4266
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏