[WIP] dependency: fine grained (user cmd filter)#4363
Closed
casperdcl wants to merge 11 commits into
Closed
Conversation
casperdcl
commented
Aug 8, 2020
Contributor
Author
There was a problem hiding this comment.
not sure if there are aspects of stage.run.cmd_run which should be used here
casperdcl
commented
Aug 8, 2020
Comment on lines
102
to
105
Contributor
Author
There was a problem hiding this comment.
not sure if this is required - maybe automatically handled elsewhere (i.e. entire tmpdir deleted before exit)
a469eb4 to
aa4cd31
Compare
casperdcl
commented
Aug 8, 2020
Contributor
Author
There was a problem hiding this comment.
maybe assert not required (should be handled by schema)?
Collaborator
There was a problem hiding this comment.
Other CLI commands can create/load dependencies, skipping the schema. Good to have an assert.
TODO: insert cmd into dvc.lock
Contributor
|
Closing for now, we'll get back after dep/out refactor to properly accommodate this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dvc.yamldvc.lockdvc.yaml:stages.<stage>.deps.[].<path>.cmd)dvc.lockdvc run -d "utils.py:extract_function.py --name check_db"Note that this implementation
PARAM_FILTER = "cmd"pathas a positional argument to the user-definedcmdcmdoutputcmd: catschema:
testing: