Skip to content

tests: add .dvcignore on the tests expectations#4396

Merged
skshetry merged 1 commit into
treeverse:masterfrom
skshetry:tests-dvcignore-expect
Aug 15, 2020
Merged

tests: add .dvcignore on the tests expectations#4396
skshetry merged 1 commit into
treeverse:masterfrom
skshetry:tests-dvcignore-expect

Conversation

@skshetry
Copy link
Copy Markdown
Collaborator

Since #4229, we have started creating .dvcignore file after dvc init
This commit only adds that in assertions

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

Since treeverse#4229, we have started creating .dvcignore file after `dvc init`
This commit only adds that in assertions
@skshetry skshetry added c1-quick-fix testing Related to the tests and the testing infrastructure labels Aug 15, 2020
@skshetry skshetry self-assigned this Aug 15, 2020
@skshetry
Copy link
Copy Markdown
Collaborator Author

Comments related to tests in #4381 (review) has also been fixed.

It's a simple change, don't want to wait. Merging ...

@skshetry skshetry merged commit b773ba7 into treeverse:master Aug 15, 2020
@skshetry skshetry deleted the tests-dvcignore-expect branch August 15, 2020 15:39
@efiop
Copy link
Copy Markdown
Contributor

efiop commented Aug 15, 2020

Thank you! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Related to the tests and the testing infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants