Skip to content

Yaml with trees#4425

Merged
efiop merged 1 commit into
treeverse:masterfrom
skshetry:yaml-uses-tree
Aug 20, 2020
Merged

Yaml with trees#4425
efiop merged 1 commit into
treeverse:masterfrom
skshetry:yaml-uses-tree

Conversation

@skshetry
Copy link
Copy Markdown
Collaborator

@skshetry skshetry commented Aug 19, 2020 •
edited
Loading

  • Also fixes plots not getting dumped on flow style

  • Make serialization utils aware of trees

  • Directly load yamls/tomls using utils, rather than using parser

  • ❗ I have followed the Contributing to DVC checklist.

  • 📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

On top of #4415, see #4415 (comment)

@skshetry skshetry self-assigned this Aug 19, 2020
@skshetry skshetry mentioned this pull request Aug 19, 2020
Merged
2 tasks
@skshetry skshetry marked this pull request as ready for review August 19, 2020 15:13
@skshetry skshetry requested review from efiop, pared and pmrowla August 19, 2020 15:13
@skshetry skshetry mentioned this pull request Aug 19, 2020
Merged
2 tasks
@skshetry
Copy link
Copy Markdown
Collaborator Author

skshetry commented Aug 19, 2020

Tests failing because of some hdfs issue:

=========================== short test summary info ============================
FAILED tests/func/test_data_cloud.py::test_cloud[hdfs]
ERROR tests/func/test_api.py::test_open_granular[hdfs] - PermissionError: [Er...
ERROR tests/func/test_api.py::test_missing[hdfs] - PermissionError: [Errno 13...
ERROR tests/func/test_data_cloud.py::test_cloud_cli[hdfs] - PermissionError: ...
ERROR tests/func/test_update.py::test_update_import_url[hdfs] - PermissionErr...

Too much bad luck today with the tests, must be #4230.

@skshetry
Make serializing utils use tree, misc changes
0f452f0 
* Also fixes plots not getting dumped on flow style
* Make serialization utils aware of trees
* Directly load yamls/tomls using utils, rather than using parser
@efiop efiop merged commit de0fe94 into treeverse:master Aug 20, 2020
@skshetry skshetry deleted the yaml-uses-tree branch August 20, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efiop efiop Awaiting requested review from efiop

2 more reviewers

@pmrowla pmrowla pmrowla approved these changes

@pared pared pared approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@skshetry skshetry

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@skshetry @pmrowla @pared @efiop