You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is sorting file paths based on name necessary?
Because looking at code, only for --show-md we are sorting files.
For default and show-json we are not sorting files. But doc string says files will be sorted for better readability here
Any inputs on this. I still feel json and default formats of dvc diff is not sorting file names ❗
Only sorting in markdown seems inconsistent.. 😟
@PuneethaPai Thank you for your patience! Good catch! Indeed, for json it doesn't really matter, since it is meant for programmatic use anyways. But default output would indeed benefit from sorting. Added checkbox in #2982
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4313
PS: there may be scope for refactoring. Inputs are welcome ❗ 😄