Skip to content

fix get-url not fetching from url that does not support HEAD request #4646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
efiop merged 6 commits into from
Oct 12, 2020
Merged

fix get-url not fetching from url that does not support HEAD request #4646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3ae9487
bug fixed
Sep 30, 2020
fa5db47
bug #4251 fixed
Sep 30, 2020
f524c72
bug #4251 fixed
Sep 30, 2020
28e99f8
Revert "bug #4251 fixed https://github.com/iterative/dvc/issues/4251"
hl-a-k Oct 3, 2020
13a27a1
Revert "bug #4251 fixed https://github.com/iterative/dvc/issues/4251"
hl-a-k Oct 3, 2020
b7203ed
Fix bug #4251
hl-a-k Oct 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dvc/repo/get_url.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ def get_url(url, out=None):

(dep,) = dependency.loads_from(None, [url])
(out,) = output.loads_from(None, [out], use_cache=False)
dep.save()
if not dep.exists:
Copy link
Copy Markdown
Contributor

@efiop efiop Oct 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I totally forgot that the issue itself was about exist not working for some urls πŸ™ So this won't actually solve it. My mistake, sorry for the confusion.

Ok, let me see if the exception approach mentioned above is feasible to implement...

Copy link
Copy Markdown
Contributor Author

@hl-a-k hl-a-k Oct 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least, this approach work for #4251 . I have tested.

Copy link
Copy Markdown
Contributor Author

@hl-a-k hl-a-k Oct 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is the current situation？

Copy link
Copy Markdown
Contributor

@efiop efiop Oct 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't get to research this yet. Need to confirm this and we'll merge if it is indeed fixed. Looks good as is. Thanks!

Copy link
Copy Markdown
Contributor

@efiop efiop Oct 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hl-a-k Thanks for your patience! Indeed, it was the get_hash that was causing that issue, so the current solution works like charm. Thank you! πŸ™

raise dep.DoesNotExistError(dep)
dep.download(out)
out.save()
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ def run(self):
name="dvc",
version=version,
description="Git for data scientists - manage your code and data together",
long_description=open("README.rst", "r").read(),
long_description=open("README.rst", "r", encoding="UTF-8").read(),
Copy link
Copy Markdown
Contributor

@efiop efiop Oct 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nice catch!

author="Dmitry Petrov",
author_email="dmitry@dvc.org",
download_url="https://github.com/iterative/dvc",
Expand Down